[PR #8320/9ba9a4e5 backport][3.9] Fix Python parser to mark responses…

… without length as closing (#8321) **This is a backport of PR #8320 as merged into master (9ba9a4e).** Co-authored-by: Sam Bull <[email protected]>
aio-libs · Apr 11, 2024 · a7e240a · a7e240a
1 parent 2833552
commit a7e240a
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/CHANGES/8320.bugfix.rst b/CHANGES/8320.bugfix.rst
@@ -0,0 +1 @@
+Fixed the pure python parser to mark a connection as closing when a response has no length -- by :user:`Dreamsorcerer`.
diff --git a/aiohttp/http_parser.py b/aiohttp/http_parser.py
@@ -718,7 +718,16 @@ def parse_message(self, lines: List[bytes]) -> RawResponseMessage:
         ) = self.parse_headers(lines)
 
         if close is None:
-            close = version_o <= HttpVersion10
+            if version_o <= HttpVersion10:
+                close = True
+            # https://www.rfc-editor.org/rfc/rfc9112.html#name-message-body-length
+            elif 100 <= status_i < 200 or status_i in {204, 304}:
+                close = False
+            elif hdrs.CONTENT_LENGTH in headers or hdrs.TRANSFER_ENCODING in headers:
+                close = False
+            else:
+                # https://www.rfc-editor.org/rfc/rfc9112.html#section-6.3-2.8
+                close = True
 
         return RawResponseMessage(
             version_o,

diff --git a/tests/test_http_parser.py b/tests/test_http_parser.py
@@ -735,7 +735,7 @@ def test_max_header_value_size_continuation_under_limit(response) -> None:
     assert msg.version == (1, 1)
     assert msg.headers == CIMultiDict({"data": "test " + value.decode()})
     assert msg.raw_headers == ((b"data", b"test " + value),)
-    # assert not msg.should_close  # TODO: https://github.com/nodejs/llhttp/issues/354
+    assert msg.should_close
     assert msg.compression is None
     assert not msg.upgrade
     assert not msg.chunked