Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode not nessesary here #295

Closed
wants to merge 3 commits into from
Closed

Conversation

alex-eri
Copy link
Contributor

fixes #294

@codecov
Copy link

codecov bot commented Jun 12, 2018

Codecov Report

Merging #295 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #295   +/-   ##
=======================================
  Coverage   97.08%   97.08%           
=======================================
  Files           4        4           
  Lines         206      206           
  Branches       25       25           
=======================================
  Hits          200      200           
  Misses          4        4           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ecf2b6...78a198a. Read the comment docs.

@asvetlov
Copy link
Member

The PR changes semantix.
Was "encoder/decoder are convertes between object and str".
Now "decoder is a converter from str to object if it is exactly json.loads, otherwise it converts from bytes to object. Encoder semantics is not changed".

Sorry, cannot accept such change. It is at least not backward compatible.

@asvetlov asvetlov closed this Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decoding data is not nesessary on some Redis configurations
2 participants