Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation error due to missing CHANGES.rst. #402

Merged
merged 2 commits into from
Nov 23, 2020

Conversation

jameshilliard
Copy link
Contributor

Fixes:

Traceback (most recent call last):
  File "/home/buildroot/buildroot/output/build/python-aiohttp-jinja2-1.4.1/setup.py", line 41, in <module>
    long_description="\n\n".join((read("README.rst"), read("CHANGES.rst"))),
  File "/home/buildroot/buildroot/output/build/python-aiohttp-jinja2-1.4.1/setup.py", line 29, in read
    return open(os.path.join(os.path.dirname(__file__), f)).read().strip()
FileNotFoundError: [Errno 2] No such file or directory: '/home/buildroot/buildroot/output/build/python-aiohttp-jinja2-1.4.1/CHANGES.rst'

Fixes:
Traceback (most recent call last):
  File "/home/buildroot/buildroot/output/build/python-aiohttp-jinja2-1.4.1/setup.py", line 41, in <module>
    long_description="\n\n".join((read("README.rst"), read("CHANGES.rst"))),
  File "/home/buildroot/buildroot/output/build/python-aiohttp-jinja2-1.4.1/setup.py", line 29, in read
    return open(os.path.join(os.path.dirname(__file__), f)).read().strip()
FileNotFoundError: [Errno 2] No such file or directory: '/home/buildroot/buildroot/output/build/python-aiohttp-jinja2-1.4.1/CHANGES.rst'
@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #402 (8849dbf) into master (4328fbd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #402   +/-   ##
=======================================
  Coverage   96.25%   96.25%           
=======================================
  Files           3        3           
  Lines         160      160           
  Branches       18       18           
=======================================
  Hits          154      154           
  Misses          6        6           
Flag Coverage Δ
unit 95.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4328fbd...8849dbf. Read the comment docs.

Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jameshilliard
Copy link
Contributor Author

@asvetlov

Merge branch 'master' into fix-install

I think you did the merge in the wrong direction.

@webknjaz
Copy link
Member

@jameshilliard it's not wrong. It's meant to confirm that this branch is up to date with the current master.

@jameshilliard
Copy link
Contributor Author

@webknjaz Wouldn't that be obvious from the commit log? Or am I missing something?

@asvetlov
Copy link
Member

That's how github works when I enable "Require branches to be up to date before merging" branch protection and press "Update" button.

@asvetlov asvetlov merged commit a3f28dc into aio-libs:master Nov 23, 2020
@asvetlov
Copy link
Member

Now the fix is merged, preparing a bugfix release

@jameshilliard jameshilliard deleted the fix-install branch November 23, 2020 18:55
@jameshilliard
Copy link
Contributor Author

That's how github works when I enable "Require branches to be up to date before merging" branch protection and press "Update" button.

Weird, that's a strange way of implementing that feature.

@webknjaz
Copy link
Member

@jameshilliard it's pretty standard. Besides, GitHub only blocks outdated PRs, it does not dictate a specific way of making it up-to-date. Another way is to ask the contributor, you, to do a rebase but this would mean more delays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants