-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix installation error due to missing CHANGES.rst. #402
Conversation
Fixes: Traceback (most recent call last): File "/home/buildroot/buildroot/output/build/python-aiohttp-jinja2-1.4.1/setup.py", line 41, in <module> long_description="\n\n".join((read("README.rst"), read("CHANGES.rst"))), File "/home/buildroot/buildroot/output/build/python-aiohttp-jinja2-1.4.1/setup.py", line 29, in read return open(os.path.join(os.path.dirname(__file__), f)).read().strip() FileNotFoundError: [Errno 2] No such file or directory: '/home/buildroot/buildroot/output/build/python-aiohttp-jinja2-1.4.1/CHANGES.rst'
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
=======================================
Coverage 96.25% 96.25%
=======================================
Files 3 3
Lines 160 160
Branches 18 18
=======================================
Hits 154 154
Misses 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I think you did the merge in the wrong direction. |
@jameshilliard it's not wrong. It's meant to confirm that this branch is up to date with the current master. |
@webknjaz Wouldn't that be obvious from the commit log? Or am I missing something? |
That's how github works when I enable "Require branches to be up to date before merging" branch protection and press "Update" button. |
Now the fix is merged, preparing a bugfix release |
Weird, that's a strange way of implementing that feature. |
@jameshilliard it's pretty standard. Besides, GitHub only blocks outdated PRs, it does not dictate a specific way of making it up-to-date. Another way is to ask the contributor, you, to do a rebase but this would mean more delays. |
Fixes: