Upgrade middleware to new style from aiohttp 2.3+ #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 97 96 -1
Branches 13 13
=====================================
- Hits 97 96 -1
Continue to review full report at Codecov.
|
|
Change looks good, if we going to use this approach we should also bump minimum aiohttp version in |
juliatem
force-pushed
the
updgrade-middleware
branch
from
ad525b6 to
3094a6d
Compare
|
@jettify I've updated setup.py |
asvetlov
approved these changes
Jan 26, 2018
|
I'd like to wait for #179 before making a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.