Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Vary: Origin header when the response headers vary according to the origin. #366

Closed
wants to merge 1 commit into from

Conversation

JulienPalard
Copy link

What do these changes do?

According to the fetch spec, I added a Vary: Origin when the response varies according to the origin, to avoid cache issues (like an Access-Control-Allow-Origin for a domain being cached then delivered to other origins).

Are there changes in behavior for the user?

It should fix some cache issues, typically when the responses get through an HTTP cache like Varnish.

Related issue number

Closes #351

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@JulienPalard JulienPalard closed this by deleting the head repository Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should aiohttp-cors add a Vary: Origin when emitting a access-control-allow-origin?
1 participant