Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove outdated codes that use 'AsyncCM' interface #874

Merged

Conversation

fregataa
Copy link
Contributor

@fregataa fregataa commented Jul 4, 2024

follow up #861 #850

_AsynCM interface has a docker query coroutine as an attribute and #861 allowed the coroutine to be closed.
#850 removed the _AsynCM interface but there is still remaining codes that try to call the method of the interface.
Let's remove it.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the changes folder
    • name it <issue_id>.<type> for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.19%. Comparing base (7150ccc) to head (4baf4b2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #874      +/-   ##
==========================================
+ Coverage   81.14%   81.19%   +0.05%     
==========================================
  Files          24       24              
  Lines        1421     1420       -1     
  Branches      253      253              
==========================================
  Hits         1153     1153              
+ Misses        175      174       -1     
  Partials       93       93              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add type annotation to the method so that it could be type-checked.

Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have revised the PR.

@achimnol achimnol enabled auto-merge (squash) July 5, 2024 07:11
@achimnol achimnol disabled auto-merge July 5, 2024 07:11
@achimnol achimnol enabled auto-merge (squash) July 5, 2024 07:14
@achimnol achimnol merged commit bc500f4 into aio-libs:main Jul 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants