-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix local tests #855
Fix local tests #855
Conversation
FYI: https://github.com/actions/actions-runner-controller/blob/master/runner/actions-runner.ubuntu-22.04.dockerfile#L8 |
(oops) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #855 +/- ##
==========================================
- Coverage 81.44% 81.36% -0.08%
==========================================
Files 24 24
Lines 1374 1374
Branches 245 245
==========================================
- Hits 1119 1118 -1
- Misses 169 170 +1
Partials 86 86 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge the PR and inspect other local testing issues in my setup as a follow-up. Please check out my review comments!
What do these changes do?
Fix tests to work locally with later versions of Docker.
Are there changes in behavior for the user?
No
Related issue number
#849, possibly #691
Checklist
CONTRIBUTORS.txt
changes
folder<issue_id>.<type>
for example (588.bug)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.