-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Docker context endpoints #854
base: main
Are you sure you want to change the base?
Add support for Docker context endpoints #854
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #854 +/- ##
==========================================
- Coverage 81.34% 81.06% -0.28%
==========================================
Files 24 24
Lines 1372 1389 +17
Branches 245 250 +5
==========================================
+ Hits 1116 1126 +10
- Misses 170 175 +5
- Partials 86 88 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add some test cases by providing mocked docker client configurations?
What do these changes do?
Add support for Docker context endpoints.
DOCKER_CONTEXT
will be prioritized if it is set.Are there changes in behavior for the user?
No impacts to existing users.
Related issue number
resolves #811
Checklist
CONTRIBUTORS.txt
changes
folder<issue_id>.<type>
for example (588.bug)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.