Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed connection reusage for decorators #267

Merged
merged 1 commit into from
Jun 12, 2017

Conversation

argaen
Copy link
Member

@argaen argaen commented Jun 12, 2017

when decorated function is costly connections where being kept
while being iddle. This is a bad scenario and this reverts back
to using a connection from the cache pool for every cache
operation

@codecov-io
Copy link

codecov-io commented Jun 12, 2017

Codecov Report

Merging #267 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
- Coverage   99.18%   99.17%   -0.02%     
==========================================
  Files          13       13              
  Lines         860      845      -15     
  Branches       90       88       -2     
==========================================
- Hits          853      838      -15     
  Misses          7        7
Impacted Files Coverage Δ
aiocache/decorators.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6da4085...26f4621. Read the comment docs.

when decorated function is costly connections where being kept
while being iddle. This is a bad scenario and this reverts back
to using a connection from the cache pool for every cache
operation
@argaen argaen force-pushed the bug_#260/dont_reuse_connection branch from 2413d5e to 26f4621 Compare June 12, 2017 18:50
@argaen argaen merged commit e713588 into master Jun 12, 2017
@argaen argaen deleted the bug_#260/dont_reuse_connection branch June 12, 2017 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants