Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #901 #931

Closed
wants to merge 2 commits into from
Closed

Fix #901 #931

wants to merge 2 commits into from

Conversation

achimgaedke
Copy link

Description of Change

This PR specifies the encoding for any IMDS calls explicitly, this fixes #901.

@thehesiod
Copy link
Collaborator

is there a way to add a test for this?

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #931 (fe4731d) into master (4694ba4) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #931   +/-   ##
=======================================
  Coverage   87.12%   87.12%           
=======================================
  Files          46       46           
  Lines        4969     4969           
=======================================
  Hits         4329     4329           
  Misses        640      640           
Flag Coverage Δ
unittests 87.12% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiobotocore/utils.py 71.09% <100.00%> (ø)
tests/botocore/test_utils.py 99.46% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4694ba4...fe4731d. Read the comment docs.

@thehesiod
Copy link
Collaborator

closing in favor of #934

1 similar comment
@thehesiod
Copy link
Collaborator

closing in favor of #934

@thehesiod thehesiod closed this May 5, 2022
@thehesiod thehesiod closed this May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 error : Unable to locate credentials
2 participants