Newest botocore (1.4.73) support. Fixing #55, #53 and #52. #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried to use aiobotocore for sending SMS through SNS I've got an error:
That's because botocore dependency version was pinned to >=1.4.0 <=1.4.28 because of issues #55, #53 and #52. But support for a
PhoneNumber
parameter insns.publish()
was added later. But I really needed theaiobotocore
library because I'm using Multipart Upload to S3 fromaiohttp
web server.So I spent an evening to compare the newest
botocore==1.4.73
source code with current aiobotocore modules and have fixed some incompatibilities.Now I have perfectly working aibotocore in my project. I'm using
aiohttp==1.1.1
,botocore==1.4.73
andPython 3.5.2
(with flawless async/await) to upload multipart files to S3 and SNS features (push notifications, SMS). Everything works great.I've run included tests and got 18 out of 20 passed. As you see below, 2 failed tests are related to DynamoDB and hardcoded ARN's, so I can't test them. This is related to #65 I think. But all Travis tests are passed successfully :)
I hope my pull request will be helpful and I've not missed any important places in code.