Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce multiprocessing start method spawn in test suite #1275

Merged

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

Enforce multiprocessing start method spawn in test suite.

Assumptions

Replace this text with any assumptions made (if any)

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details): closes Test suite uses unsafe multiprocessing start method fork on Linux #1274
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller self-assigned this Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.51%. Comparing base (43f8d7c) to head (0e8c280).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1275      +/-   ##
==========================================
- Coverage   87.53%   87.51%   -0.03%     
==========================================
  Files          67       67              
  Lines        5913     5917       +4     
==========================================
+ Hits         5176     5178       +2     
- Misses        737      739       +2     
Flag Coverage Δ
unittests 87.51% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller marked this pull request as ready for review January 22, 2025 09:16
@jakob-keller jakob-keller added this pull request to the merge queue Jan 22, 2025
Merged via the queue into aio-libs:master with commit d634f68 Jan 22, 2025
12 checks passed
@jakob-keller jakob-keller deleted the multiprocessing-spawn-in-tests branch January 22, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test suite uses unsafe multiprocessing start method fork on Linux
2 participants