Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger CI on merge_group event #1244

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

Trigger CI on merge_group event.

Assumptions

Repo settings will be updated according to documentation: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details): closes Run CI/CD on merge queue #1170
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller added the github_actions Pull requests that update GitHub Actions code label Dec 29, 2024
@jakob-keller jakob-keller self-assigned this Dec 29, 2024
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.10%. Comparing base (e1829d9) to head (1f90fc6).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1244      +/-   ##
==========================================
+ Coverage   88.05%   88.10%   +0.05%     
==========================================
  Files          67       67              
  Lines        5904     5904              
==========================================
+ Hits         5199     5202       +3     
+ Misses        705      702       -3     
Flag Coverage Δ
unittests 88.10% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller merged commit f9975dd into aio-libs:master Dec 29, 2024
11 checks passed
@jakob-keller jakob-keller deleted the merge_group branch December 29, 2024 14:07
@jakob-keller
Copy link
Collaborator Author

Someone with admin permissions: feel free to update repo settings accordingly.

@webknjaz
Copy link
Member

Done. Interestingly, there's only one codecov in branch protection, and no required CI checks.. That seems weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run CI/CD on merge queue
2 participants