Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline dev dependency management #1185

Merged
merged 7 commits into from
Aug 26, 2024

Conversation

jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Aug 23, 2024

Description of Change

Prepares CI/CD workflow for testing of distribution packages (#1169)

Assumptions

  • aiohttp version constraint in CI/CD workflow is no longer required
  • time statements in CI/CD workflow are no longer required

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Aug 23, 2024
@jakob-keller jakob-keller self-assigned this Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.94%. Comparing base (1aa309d) to head (feb16ab).
Report is 37 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1185      +/-   ##
==========================================
- Coverage   86.99%   86.94%   -0.06%     
==========================================
  Files          64       64              
  Lines        5983     5983              
==========================================
- Hits         5205     5202       -3     
- Misses        778      781       +3     
Flag Coverage Δ
unittests 86.94% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jakob-keller jakob-keller force-pushed the dev-requirements branch 4 times, most recently from 044c84f to 518dbc8 Compare August 23, 2024 22:01
@jakob-keller jakob-keller marked this pull request as ready for review August 23, 2024 22:18
.gitignore Show resolved Hide resolved
@webknjaz
Copy link
Member

What's the game plan here? This is definitely different from anything I've ever seen in the wild…

@thehesiod
Copy link
Collaborator

yea, was fast and lose, we should tighten it up

@jakob-keller
Copy link
Collaborator Author

jakob-keller commented Aug 24, 2024

I've opened #1188 for tracking the step-change improvement in dependency management.

Nonetheless, I believe it makes sense to do this PR now to get rid of technical debt.

@jakob-keller jakob-keller enabled auto-merge August 26, 2024 10:28
@jakob-keller jakob-keller merged commit b923ee8 into aio-libs:master Aug 26, 2024
10 checks passed
@jakob-keller jakob-keller deleted the dev-requirements branch August 26, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants