-
Notifications
You must be signed in to change notification settings - Fork 29
Allow inject connector from ElasticSearch till Connection #138
Conversation
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
==========================================
+ Coverage 81.09% 81.15% +0.06%
==========================================
Files 23 23
Lines 3533 3545 +12
Branches 725 727 +2
==========================================
+ Hits 2865 2877 +12
Misses 389 389
Partials 279 279
Continue to review full report at Codecov.
|
@popravich can you take a look to this MR? Also, I would like to ask you for a favor. could you publish a new release with the last two changes? We are having a lot of issues with the default aiohttp In any case, thanks in advance! |
aioes/transport.py
Outdated
self._loop = loop | ||
self._connector = connector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here in Transport
it should be connector_factory
,
otherwise a single connector
will be shared between different Connections
(ClientSession
s)
and when some connection will get dropped underlying ClientSession will close the shared connector
making other connections broken as well.
I think it could look like this:
connector_factory=lambda: None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, going to change it and covering it with test.
Please add test also. |
@popravich done. |
Thanks |
you welcome, any chance to get a 0.7.1 release? otherwise, any ETA? |
Ok, I will do a release in a several hours |
Related with this PR1[1], it enables inject from the upper layer the adhoc
Connection
class[1] #137