Skip to content

Commit

Permalink
doc: ensure all top dirs have an explanatory README (ooni#214)
Browse files Browse the repository at this point in the history
* doc: ensure all top dirs have an explanatory README

This makes the repository a lil bit nicer to newcomers.

Part of ooni/probe#1335

* fix: re-run bindata to embed the README

The readme is small, so we can pay the price of adding it.

On a related note, I am very pleased the Go team implemented the
`//go:embed` feature, so we can get rid of this bindata thing.
  • Loading branch information
bassosimone authored Feb 3, 2021
1 parent 749e238 commit c36e2a5
Show file tree
Hide file tree
Showing 11 changed files with 59 additions and 7 deletions.
2 changes: 1 addition & 1 deletion MOBILE/README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Directory github.com/ooni/probe-engine/MOBILE
# Directory github.com/ooni/probe-cli/MOBILE

This directory is used for building for Android and iOS.
2 changes: 1 addition & 1 deletion QA/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Tools with this shallow-compatible CLI are:

1. `github.com/ooni/probe-legacy`
2. `github.com/measurement-kit/measurement-kit/src/measurement_kit`
3. `github.com/ooni/probe-engine/cmd/miniooni`
3. `github.com/ooni/probe-engine/internal/cmd/miniooni`

## Run QA on a Linux system

Expand Down
4 changes: 4 additions & 0 deletions cmd/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Directory github.com/ooni/probe-cli/cmd

This directory contains the public binaries that you
can build from this repository.
33 changes: 33 additions & 0 deletions cmd/ooniprobe/internal/bindata/bindata.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions data/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Directory github.com/ooni/probe-cli/data

This directory contains data that is embedded into builds.
3 changes: 3 additions & 0 deletions debian/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Directory github.com/ooni/probe-cli/debian

This directory allows us to build debian packages.
3 changes: 3 additions & 0 deletions docs/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Directory github.com/ooni/probe-cli/docs

This directory contains documentation.
3 changes: 3 additions & 0 deletions internal/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Directory github.com/ooni/probe-cli/internal

This directory contains private Go packages.
3 changes: 2 additions & 1 deletion internal/cmd/README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# Directory github.com/ooni/probe-cli/internal/cmd

This directory contains the source code for the CLI tools we build
but we don't want to expose to the outside world.
but we don't want to expose to the outside world. That is, you
can only build these tools if you have cloned this repo.
7 changes: 3 additions & 4 deletions internal/libminiooni/README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Package github.com/ooni/probe-engine/libminiooni
# Package github.com/ooni/probe-cli/internal/libminiooni

Package libminiooni implements the cmd/miniooni CLI. Miniooni is our
experimental client used for research and QA testing.
Expand All @@ -9,6 +9,5 @@ OONI Probe CLI options. Perfect backwards compatibility is not a
design goal for miniooni. Rather, we aim to have as little conflict
as possible such that we can run side by side QA checks.

We extracted this package from cmd/miniooni to allow us to further
integrate the miniooni CLI into other binaries (see for example the
code at github.com/bassosimone/aladdin).
This package was split off from cmd/miniooni in ooni/probe-engine. For
now we are keeping this split, but we will merge them in the future.
3 changes: 3 additions & 0 deletions pkg/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Directory github.com/ooni/probe-cli/pkg

This directory contains public Go packages.

0 comments on commit c36e2a5

Please sign in to comment.