Python3-3.10 some quick fixes for some Quality of Life Issues #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes were all made and tested on the Python3-3.10 branch, but I have no reason to believe the same ideas can't be applied to the Python3-3.8 branch as well. I just do not have a system setup with that I can test them on.
Changes:
Logs
directory if it does not already exist when starting the program, to prevent the logger from erroring out. This should also fix issues where if the logging filepath is changed in the YAML config, the directory and file will be created properly. (There are still some hardcoded path in theLog
tab of the GUI that I want to look into getting changed next, to follow the path set in the YAML).433\\t
being passed to the next program, which fails to parse as a float, so added stripping to prevent this issue (Note: This likely could have some more checks done that is actually converts to a valid float)CTRL-C
from the command line will cause a graceful closing instead of the helper python scripts getting left open and keeping sockets open. I believe that it treats it just as X on the GUI would currently.Most of these may occur more times in the program, these are ones I happened to run into while poking around, and could get narrowed down quickly.