Udjusted the documentation regarding the creating of a pseudo family. #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to probably the latest version.
sphuber
requested changes
Oct 28, 2024
There was a problem hiding this comment.
Thanks a lot for the effort @Minotakm . You did indeed catch a number of mistakes. There were just two changes that are not necessary I believe, and if true, I would prefer to leave it as is. Let me know if reverting those two small changes still leads to a problem on your end.
Co-authored-by: Sebastiaan Huber <[email protected]>
sphuber
approved these changes
Oct 29, 2024
|
Will merge as soon as I fix the current broken CI. #175 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey All,
I tried to use the documentation available regarding the design of a new pseudo-family and I found I need to make a few small-ish adjustments to make it work. I thought it would be nice to add them in the documentation. This pull request includes updates to the code snippets on the design section of the documentation, reflecting the adjustments I made. Looking forward to your feedback.