Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SSSP v1.2 #144

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Add support for SSSP v1.2 #144

merged 1 commit into from
Dec 6, 2022

Conversation

mbercx
Copy link
Member

@mbercx mbercx commented Dec 2, 2022

No description provided.

@sphuber
Copy link
Contributor

sphuber commented Dec 2, 2022

Any reason this is still a draft? Is anything else needed?

@mbercx
Copy link
Member Author

mbercx commented Dec 6, 2022

I was still testing it but already wanted to share the update. Seems to be working fine though, so I'll change it to ready for review.

@mbercx mbercx marked this pull request as ready for review December 6, 2022 09:10
@sphuber sphuber self-requested a review December 6, 2022 09:25
sphuber
sphuber approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all good to go

@mbercx mbercx merged commit cb7e79b into aiidateam:master Dec 6, 2022
@mbercx mbercx deleted the new-sssp-1.2 branch December 6, 2022 09:35
@unkcpz
Copy link
Member

unkcpz commented Mar 13, 2023 •
edited
Loading

Hi both, I have updated the SSSP version to 1.2.1 (The new archive URL is https://archive.materialscloud.org/record/2023.38), I guess there is no need to update this repo since it will read the versions.yaml to use the latest patch version, correct?

@sphuber
Copy link
Contributor

sphuber commented Mar 13, 2023

Indeed, see here:

aiida-pseudo/src/aiida_pseudo/cli/install.py

Line 116 in 9ea1570

with attempt('downloading patch versions information... ', include_traceback=traceback):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphuber sphuber sphuber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbercx @sphuber @unkcpz