CLI: Reduce the load time significantly #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix/141/cli-load-speed
branch
from
3a7a4a7 to
2166edc
Compare
Some of the commands imported a number of resources at the top of the modules that have large loading times on first import. This was causing the load time of the CLI to be ~1.5 seconds, even when just rendering the help message. By moving the slow packages inside the commands themselves, the load time is reduced to a mere ~0.2 seconds. This makes the CLI much more snappy to use, especially when using tab-completion.
sphuber
force-pushed
the
fix/141/cli-load-speed
branch
from
2166edc to
9749f65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141
Some of the commands imported a number of resources at the top of the modules that have large loading times on first import. This was causing the load time of the CLI to be ~1.5 seconds, even when just rendering the help message.
By moving the slow packages inside the commands themselves, the load time is reduced to a mere ~0.2 seconds. This makes the CLI much more snappy to use, especially when using tab-completion.