Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: update requirement aiida-core~=2.0 #120

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Apr 28, 2022

Dependencies: update requirement aiida-core~=2.0

Adds compatibility with AiiDA v2.0. Notable changes:

  • Entry points are now loaded through built-in modules instead of the
    custom reentry, so reentry scan no longer needs to be called.
  • Tab-completion now ships with click itself, so click_completion
    and its manual activiation is removed.
  • Update entry points from aiida-core by prefixing with core.

Also enable the AIIDA_WARN_v3 environment variable in the tests job
of the CI workflow. This will print deprecation warnings from
aiida-core. These are also addressed in this commit:

  • Entity.objects -> Entity.collection
  • Node.get_attribute -> Node.base.attributes.get
  • Node.set_attribute -> Node.base.attributes.set
  • Node.get_extra -> Node.base.extras.get
  • Node.set_extra -> Node.base.extras.set
  • Node.get_object_content -> Node.base.repository.get_object_content
  • Node.add_incoming -> Node.base.links.add_incoming

Due to the updated requirements of click, the sphinx-click
dependency of the docs extra also had to be upgraded because the lower
versions had an upper limit on click.

@sphuber sphuber force-pushed the fix/compatibility-aiida-core-2.0 branch 11 times, most recently from f169fa4 to 36e7001 Compare April 28, 2022 21:00
Adds compatibility with AiiDA v2.0. Notable changes:

* Entry points are now loaded through built-in modules instead of the
  custom `reentry`, so `reentry scan` no longer needs to be called.
* Tab-completion now ships with `click` itself, so `click_completion`
  and its manual activiation is removed.
* Update entry points from `aiida-core` by prefixing with `core.`

Also enable the `AIIDA_WARN_v3` environment variable in the `tests` job
of the CI workflow. This will print deprecation warnings from
`aiida-core`. These are also addressed in this commit:

* `Entity.objects` -> `Entity.collection`
* `Node.get_attribute` -> `Node.base.attributes.get`
* `Node.set_attribute` -> `Node.base.attributes.set`
* `Node.get_extra` -> `Node.base.extras.get`
* `Node.set_extra` -> `Node.base.extras.set`
* `Node.get_object_content` -> `Node.base.repository.get_object_content`
* `Node.add_incoming` -> `Node.base.links.add_incoming`

Due to the updated requirements of `click`, the `sphinx-click`
dependency of the `docs` extra also had to be upgraded because the lower
versions had an upper limit on `click`.
@sphuber sphuber force-pushed the fix/compatibility-aiida-core-2.0 branch from 36e7001 to cd086dc Compare April 28, 2022 21:05
@sphuber sphuber merged commit a59c551 into master Apr 28, 2022
@sphuber sphuber deleted the fix/compatibility-aiida-core-2.0 branch April 28, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant