Adding Psp8 (Abinit type) pseudo support. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
requested changes
Oct 26, 2020
There was a problem hiding this comment.
Thanks @sponce24 . In addition to my comments, please add unit tests for both the data plugin as well as the family. You can literally copy paste those of the PsfData for example and just adapt to Psp8Data. I think the current implementation is broken, which shows why tests are important
|
Another tip, to get the pre-commit running automatically, do the following from the repository: This way you will automatically run pre-commit locally and it won't fail remotely |
Should be more robust.
|
@sponce24 if you fix the pre-commit, this can be merged |
sphuber
approved these changes
Oct 26, 2020
|
Thanks a lot @sponce24 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.