Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update codecov action #6420

Merged
merged 2 commits into from
May 26, 2024
Merged

Conversation

danielhollas
Copy link
Collaborator

codecov-action@v4 made the CODECOV_TOKEN mandatory for PRs from the origin (and pushes to the origin). This token needs to be generated on codecov.io and added as a repository secret.

@sphuber
Copy link
Contributor

sphuber commented May 26, 2024

I don't see the codecov action in the checks above. I take it that is because there doesn't actually seem to be a CODECOV_TOKEN secret for this repo. Or is there more that would need to be done? I am personally not really a fan of it as historically it has mostly caused more problems than I think it solves. But I wouldn't be opposed to add it again and give a it a go to see how things go.

Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.51%. Comparing base (ef60b66) to head (580eb8d).
Report is 112 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6420      +/-   ##
==========================================
- Coverage   77.51%   77.51%   -0.00%     
==========================================
  Files         560      560              
  Lines       41444    41454      +10     
==========================================
+ Hits        32120    32127       +7     
- Misses       9324     9327       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sphuber sphuber merged commit fc2a84d into aiidateam:main May 26, 2024
21 checks passed
@sphuber
Copy link
Contributor

sphuber commented May 26, 2024

Thanks @danielhollas

@danielhollas danielhollas deleted the codecov-update branch May 26, 2024 15:54
mikibonacci pushed a commit to mikibonacci/aiida-core that referenced this pull request Sep 3, 2024
The `codecov-action@v4` made the `CODECOV_TOKEN` mandatory for PRs
from the origin and pushes to the origin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants