Tests: Fix flaky work chain tests using recwarn fixture
#6112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix/flaky-log-test
branch
2 times, most recently
from
d1a3cdb to
5143e01
Compare
The tests were often failing because the `recwarn` fixture contained two records instead of one. The reason is that elsewhere in the code a `ResourceWarning` is emitted because an event-loop is not closed when another one is created. Until this is fixed, the assertion is updated to not check for the number of warnings emitted, but specifically to check the expected warning message is present.
sphuber
force-pushed
the
fix/flaky-log-test
branch
from
5143e01 to
5e800f6
Compare
sphuber
changed the title
recwarn fixturerecwarn fixture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests were often failing because the
recwarnfixture containedtwo records instead of one. The reason is that elsewhere in the code a
ResourceWarningis emitted because an event-loop is not closed whenanother one is created. Until this is fixed, the assertion is updated to
not check for the number of warnings emitted, but specifically to check
the expected warning message is present.