Dependencies: Add compatibility for pymatgen>=v2023.9.2
#6109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
sphuber
force-pushed
the
fix/pymatgen
branch
6 times, most recently
from
b16a546 to
620f61a
Compare
As of v2023.9.2, the ``properties`` argument of the `Specie` class is removed and the ``spin`` argument should be used instead. See: materialsproject/pymatgen@118c245 The ``spin`` argument was introduced in v2023.6.28. See: materialsproject/pymatgen@9f2b393 Instead of removing support for versions older than v2023.6.28 the code is updated to be able to deal with the new version where `properties` is no longer supported.
sphuber
force-pushed
the
fix/pymatgen
branch
from
620f61a to
c65e551
Compare
sphuber
added a commit
that referenced
this pull request
Nov 14, 2023
As of v2023.9.2, the ``properties`` argument of the `Specie` class is removed and the ``spin`` argument should be used instead. See: materialsproject/pymatgen@118c245 The ``spin`` argument was introduced in v2023.6.28. See: materialsproject/pymatgen@9f2b393 Instead of removing support for versions older than v2023.6.28 the code is updated to be able to deal with the new version where `properties` is no longer supported. Cherry-pick: 4e0e7d8
sphuber
added a commit
that referenced
this pull request
Nov 15, 2023
As of v2023.9.2, the ``properties`` argument of the `Specie` class is removed and the ``spin`` argument should be used instead. See: materialsproject/pymatgen@118c245 The ``spin`` argument was introduced in v2023.6.28. See: materialsproject/pymatgen@9f2b393 Instead of removing support for versions older than v2023.6.28 the code is updated to be able to deal with the new version where `properties` is no longer supported. Cherry-pick: 4e0e7d8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of v2023.9.2, the
propertiesargument of theSpecieclass is removed and thespinargument should be used instead. See: materialsproject/pymatgen@118c245The
spinargument was introduced in v2023.6.28. See: materialsproject/pymatgen@9f2b393Instead of removing support for versions older than v2023.6.28 the code is updated to be able to deal with the new version where
propertiesis no longer supported.