Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump wrapt version to 1.14 fix conda install issue for py310 #5698

Closed
wants to merge 3 commits into from

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Oct 12, 2022

wrapt conda forge don't have py3.10 support for the wrapt=1.11.
Bump it to 1.14 so can be installed by conda with python 3.10.

@unkcpz unkcpz requested a review from sphuber October 12, 2022 21:13
@unkcpz
Copy link
Member Author

unkcpz commented Oct 12, 2022

There is also an issue with the conda install CI test, it passed but actually, it failed. https://github.com/aiidateam/aiida-core/actions/runs/3231971798/jobs/5305795322

I guess it resolve the version but can not find the correct one and fallback to old version.

@unkcpz
Copy link
Member Author

unkcpz commented Oct 13, 2022

Do I need to update the requirements-*.txt manually?

@sphuber
Copy link
Contributor

sphuber commented Oct 13, 2022

Normally this is done automatically by the test-install/check-requirements job but that failed in the commit action: https://github.com/aiidateam/aiida-core/actions/runs/3237939116/jobs/5305812604
Might be transient problem or maybe that action is broken.

@unkcpz
Copy link
Member Author

unkcpz commented Oct 13, 2022

It seems it need write permission for this peter-evans/commit-comment step in CI workflow. The workflow end up with error "Error: Resource not accessible by integration"

Current runner version: '2.298.2'
Operating System
Runner Image
Runner Image Provisioner
GITHUB_TOKEN Permissions
  Actions: read
  Checks: read
  Contents: read
  Deployments: read
  Discussions: read
  Issues: read
  Metadata: read
  Packages: read
  Pages: read
  PullRequests: read
  RepositoryProjects: read
  SecurityEvents: read
  Statuses: read

@unkcpz
Copy link
Member Author

unkcpz commented Oct 13, 2022

As github/codeql-action#464 (comment) suggested. Maybe change setting to:

permissions:
  security-events: write

@unkcpz unkcpz force-pushed the bumpver/wrapt branch 4 times, most recently from 2959484 to 881b9cc Compare October 13, 2022 13:47
@unkcpz
Copy link
Member Author

unkcpz commented Oct 13, 2022

Okay, I make some tests by playing around the permissions: but it did not take effect here. It take effect from my own forked repository.
I find from here that it is limited by the organization. I think it needs to be admin of the aiidateam to change it.
I guess it is @giovannipizzi?

@sphuber
Copy link
Contributor

sphuber commented Oct 19, 2022

By the way @unkcpz why is this update in dependency for wrapt even necessary? The wrapt~=1.11 allows to install wrapt==1.14 and up just fine. What is this change even accomplishing?

@unkcpz
Copy link
Member Author

unkcpz commented Oct 20, 2022

We use mamba to install aiida-core from conda-forge in aiidalab-docker-stack, if the python version pinned to py3.10, it failed with:

Pinned packages:
  - python 3.10.*


Encountered problems while solving:
  - package aiida-core-2.0.4-pyh1a96a4e_0 requires wrapt ~=1.11.1, but none of the providers can be installed

But you are right, ~=1.11 can install ~=1.14, and if using conda instead of mamba it shows a different dependency error.

UnsatisfiableError: The following specifications were found to be incompatible with each other:

Output in format: Requested package -> Available versionsThe following specifications were found to be incompatible with your system:

  - feature:/linux-64::__glibc==2.31=0
  - feature:|@/linux-64::__glibc==2.31=0

Your installed version is: 2.31

So it is not the issue of wrapt, I'll close this for now.

@unkcpz unkcpz closed this Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants