Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 IMPROVE: Warning message for group with no entry point #5076

Merged
merged 4 commits into from
Aug 13, 2021
Merged

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Aug 12, 2021

fixes #3919

@chrisjsewell chrisjsewell requested a review from sphuber August 12, 2021 22:32
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #5076 (da3d0cf) into develop (c041163) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5076      +/-   ##
===========================================
+ Coverage    80.47%   80.47%   +0.01%     
===========================================
  Files          531      531              
  Lines        36950    36951       +1     
===========================================
+ Hits         29731    29732       +1     
  Misses        7219     7219              
Flag Coverage Δ
django 74.99% <100.00%> (+0.01%) ⬆️
sqlalchemy 73.89% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida/orm/groups.py 94.74% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c041163...da3d0cf. Read the comment docs.

@sphuber sphuber merged commit 77aa5a4 into develop Aug 13, 2021
@sphuber sphuber deleted the fix/#3919 branch August 13, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

group error message needs to contain instructions on what to do
2 participants