Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests of export archive migration into aiida-core #3059

Merged

Conversation

CasperWA
Copy link
Contributor

@CasperWA CasperWA commented Jun 20, 2019

Fixes aiida-export-migration-tests' issue.

In order to easier skip tests from aiida-core (using unittest.skip()), the tests that were implemented in the aiida-export-migration-tests repo have been moved to aiida-core under aiida.backends.tests.tools.importexport.migration..

Furthermore, the accompanying utility functions have been merged into aiida.backends.tests.utils.archives.

Note: There is no need to change the version dependency of aiida-export-migration-tests, however, a new version should be released and used in PR #3052. However, I will not introduce this change until this PR has been merged, since more changes will need to be done to the imports of these test-files.
Edit: I have upped the dependency of aiida-export-migration-tests to v0.5.2.

@CasperWA CasperWA requested a review from sphuber June 20, 2019 15:10
@CasperWA CasperWA force-pushed the move_back_export_migration_tests branch from 308c091 to d2992b7 Compare June 20, 2019 15:37
@coveralls
Copy link

coveralls commented Jun 20, 2019

Coverage Status

Coverage increased (+0.03%) to 73.794% when pulling 573eb58 on CasperWA:move_back_export_migration_tests into f12dc59 on aiidateam:develop.

@CasperWA CasperWA added this to the v1.0.0 milestone Jun 21, 2019
In order to easier skip tests from aiida-core (using `unittest.skip()`),
the tests that were implemented in the `aiida-export-migration-tests` repo have been moved to
aiida-core under `aiida.backends.tests.tools.importexport.migration.`

Furthermore, the accompanying utility functions have been merged into
`aiida.backends.tests.utils.archives`

Dependancy on `aiida-export-migration-tests` has been upped to 0.5.2
@CasperWA CasperWA force-pushed the move_back_export_migration_tests branch from d2992b7 to 573eb58 Compare June 21, 2019 08:40
@CasperWA
Copy link
Contributor Author

CasperWA commented Jun 21, 2019

Got the following error in Travis for the build backend=sqlalchemy, test_type=tests:

test_attribute_key_changes (aiida.backends.sqlalchemy.tests.test_migrations.TestCalcAttributeKeysMigration)
Verify that the keys are successfully changed of the affected attributes. ... 

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

The build has been terminated

I have restarted the build job to see if I get the same error again.

Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant! Thanks @CasperWA

@sphuber sphuber merged commit 0d82872 into aiidateam:develop Jun 21, 2019
@CasperWA CasperWA deleted the move_back_export_migration_tests branch June 21, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants