Skip to content

Commit

Permalink
CI: Test with newer RabbitMQ versions
Browse files Browse the repository at this point in the history
Version 3.6/3.7 are super old and unsupported,
let's test with newer, supported versions instead.

We still want to support v3.8, since that's the last one
that doesn't require any extra configuration (i.e. setting longer
timeouts), but this version is tested as part of normal tests in ci-code.yml

Since AiiDA interacts with RabbitMQ only via the kiwipy interface,
it's unlikely that changes to AiiDA would break it. Therefore, the
RabbitMQ tests are moved to the nightly run.
  • Loading branch information
danielhollas committed May 27, 2024
1 parent 6291acc commit eccf2db
Show file tree
Hide file tree
Showing 2 changed files with 47 additions and 59 deletions.
48 changes: 47 additions & 1 deletion .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ concurrency:

jobs:

tests:
nightly-tests:

if: github.repository == 'aiidateam/aiida-core' # Prevent running the builds on forks as well
runs-on: ubuntu-latest
Expand Down Expand Up @@ -88,3 +88,49 @@ jobs:
SLACK_COLOR: b60205
SLACK_TITLE: Nightly build of `aiida-core/main` failed
SLACK_MESSAGE: The tests of the `nightly.yml` GHA worklow failed.


# Run a subset of test suite to ensure compatibility with latest RabbitMQ releases
rabbitmq_tests:

runs-on: ubuntu-latest
timeout-minutes: 30

strategy:
fail-fast: false
matrix:
# Currently supported RMQ versions per:
# https://www.rabbitmq.com/docs/which-erlang#compatibility-matrix
rabbitmq-version: ['3.11', '3.12', '3.13']

services:
postgres:
image: postgres:16
env:
POSTGRES_DB: test_aiida
POSTGRES_PASSWORD: ''
POSTGRES_HOST_AUTH_METHOD: trust
options: >-
--health-cmd pg_isready
--health-interval 10s
--health-timeout 5s
--health-retries 5
ports:
- 5432:5432
rabbitmq:
image: rabbitmq:${{ matrix.rabbitmq-version }}-management
ports:
- 5672:5672
- 15672:15672

steps:
- uses: actions/checkout@v4

- name: Install aiida-core
uses: ./.github/actions/install-aiida-core

- name: Install system dependencies
run: sudo apt update && sudo apt install postgresql

- name: Run tests
run: pytest -sv -k 'requires_rmq'
58 changes: 0 additions & 58 deletions .github/workflows/rabbitmq.yml

This file was deleted.

0 comments on commit eccf2db

Please sign in to comment.