Adding check for the raw calculation to see if lammps has exited with an error #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an error. Addresses aiidaplugins#87
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #90 +/- ##
===========================================
+ Coverage 85.30% 85.86% +0.56%
===========================================
Files 19 19
Lines 1599 1606 +7
===========================================
+ Hits 1364 1379 +15
+ Misses 235 227 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hi @sphuber! No there is no test for this, so I'll add one for both parsers. |
|
@sphuber tests added. If you agree I'll merge this one. |
sphuber
approved these changes
Nov 28, 2023
JPchico
deleted the
87-return-non-zero-exit-code-if-lammps-errors-out-in-the-raw-calculation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding check for the raw calculation to see if lammps has exited with an error. Addresses #87