Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseLammpsCalculation: Add the optional settings input #64

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

sphuber
Copy link
Member

@sphuber sphuber commented Mar 23, 2023

For now it supports the key additional_cmdline_params, which takes a list of strings that when specified is appended to the cmdline_params that are set on the CodeInfo. This is useful if LAMMPS needs to be invoked with custom parameters.

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #64 (1ec6272) into develop (ed59902) will increase coverage by 0.01%.
The diff coverage is 92.85%.

@@             Coverage Diff             @@
##           develop      #64      +/-   ##
===========================================
+ Coverage    90.23%   90.24%   +0.01%     
===========================================
  Files           32       32              
  Lines         2426     2439      +13     
===========================================
+ Hits          2189     2201      +12     
- Misses         237      238       +1     
Flag Coverage Δ
pytests 90.24% <92.85%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida_lammps/calculations/lammps/base.py 96.07% <92.85%> (-0.56%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

For now it supports the key `additional_cmdline_params`, which takes a
list of strings that when specified is appended to the `cmdline_params`
that are set on the `CodeInfo`. This is useful if LAMMPS needs to be
invoked with custom parameters.
@sphuber sphuber force-pushed the feature/additional-cmdline-parameters branch from 91002f9 to 1ec6272 Compare March 23, 2023 08:13
Copy link
Collaborator

@JPchico JPchico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks for this @sphuber !

@JPchico JPchico merged commit 3167f7f into develop Mar 23, 2023
@sphuber sphuber deleted the feature/additional-cmdline-parameters branch March 23, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants