Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 FIX: Examples #19

Merged
merged 2 commits into from
Nov 1, 2020
Merged

🐛 FIX: Examples #19

merged 2 commits into from
Nov 1, 2020

Conversation

JPchico
Copy link
Collaborator

@JPchico JPchico commented Oct 21, 2020

Removed the passing of structure from the examples and the README.md, and made used of the potential dictionaries to pass the data to the EmpiricalPotential instances.

Addresses #18

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   77.07%   77.07%           
=======================================
  Files          35       35           
  Lines        2281     2281           
=======================================
  Hits         1758     1758           
  Misses        523      523           
Flag Coverage Δ
#pytests 77.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d367350...2c35ea2. Read the comment docs.

@chrisjsewell
Copy link
Member

thanks!

@chrisjsewell chrisjsewell self-requested a review November 1, 2020 21:24
@chrisjsewell chrisjsewell changed the title Fixing the examples so that they correspond to the new potential setup. 🐛 FIX: Examples Nov 1, 2020
@chrisjsewell chrisjsewell merged commit 5592b68 into aiidaplugins:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants