Distribute package as both ESM and CJS #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump, this is affecting me as well. @aidenwallis could this PR be merged? |
aidenwallis
approved these changes
May 5, 2024
|
Are there plans to make a new release so that I can use these changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exampleproject.Description
This PR introduces dual module support for
kysely-d1, enabling it to export as both ESM and CommonJS modules. This enhancement is in line with the current module strategy adopted bykysely.Before and After Impact
Previously, when importing
kysely-d1alongsidekyselyin a project that prefers ESM,kysely-d1would still import the CJS version ofkysely, leading to inefficiencies and a larger bundle size. The dependency tree prior to this change is illustrated below:With the introduction of both ESM and CJS exports, projects can now import the ESM version of
kysely, optimizing the bundle size and improving loading times. The updated dependency tree, showcasing the more efficient structure, is shown here:This change has led to a 60% reduction in the size of
kyselywithin the bundle, decreasing from 286KB to 114KB.