add numAffectedRows @ D1Connection.executeQuery.
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidenwallis
reviewed
Dec 11, 2022
aidenwallis
approved these changes
Jan 13, 2023
|
Heads up, released your change in |
adam-the
pushed a commit
to adam-the/kysely-d1
that referenced
this pull request
Aug 20, 2023
* add `numAffectedRows` @ `D1Connection.executeQuery`. * bump kysely to 0.23.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exampleproject.Wrangler's inspector port is blocked on my wsl2 machine. 🤷
Description
aligns with kysely-org/kysely#188 (not released yet)
QueryResult.numUpdatedOrDeletedRowsis being deprecated in nextkyselyrelease, and will be removed in the future. It is being replaced withQueryResult.numAffectedRowsfor reasons discussed in linked pull request.