Add option for case sensitive inputs

[josephrexme]

new Rivescript({ caseSensitive: true }) would return inputs
without calling toLowerCase() on them. Fixes #245

[josephrexme]

I narrowed this down and found out that I had called

unless @caseSensitive?

which means something different from what I intended

unless @caseSensitive is true

[kirsle]

Can you add some unit tests for this?

[josephrexme]

Done

[kirsle]

I was hoping for a test that the non-wildcard parts of triggers still match correctly too. 😄

I checked out your branch to do some poking at it myself. It has a problem matching this trigger:

+ say *
- Umm... "<star>"

Output:

// on current master branch
You> say HellO WorlD!
Bot> Umm... "hello world"
You> SAY hello world
Bot> Umm... "hello world"

// on addCaseSensitiveInputs
You> say hello
Bot> Umm... "hello"
You> say HELLO
Bot> Umm... "HELLO"
You> SAY hello
Bot> That is interesting. Please continue.
You> Say HEllo World
Bot> Tell me more about that.

The regexps that match triggers should use the case insensitive flag. Around here is one place to update, and the %previous code might need to update too.

[josephrexme]

I guess that's the expected behavior. My goal wasn't to make the matchers case insensitive. It is to make the inputs case sensitive so if you have a SAY hello you should have a matcher that fits
+ SAY *. Else use without the caseSensitive option. So it'd be a tradeoff of the whole benefits from case insensitivity. I think trying to make an exception for the non-wildcards parts to remain case insensitive might 1. be over-engineering 2. lead to someone wanting the matchers case sensitive some day and proposing another option hence bloating the library. When people making the choice of staying case sensitive could just deal with it all that comes with it. Personally I had to just create optional non-wildcard options like:

+ (say|Say|SAY) *
- Umm... <star>

[josephrexme]

As an update on this @kirsle I actually added the insensitive flag to those lines and a test for say hello HELLO kept failing with "No Reply Matched"

[josephrexme]

Negative. I didn't compile when I tested. It should be all good now. Also, I'm sorry I was after my own selfish need initially. Thought this through and saw why you requested it

[KAKwit]

I have a specific circumstance where I need to ask the user to copy / paste an ID, which I'll then use to look up some info for them. The ID is unfortunately case sensitive. Since this change is a global thing, it wouldn't help. I'm wondering if there can be an option in the reply methods or something for specifying this, or perhaps a way to make a single topic case sensitive?

(I'm very new to this thing so apologies if this is a stupid question, but this scenario is a real world one and I'm thinking others would be likely to come across it as well).

[josephrexme]

@kirsle I don't know if you've seen this yet. What do you think? I wonder why it's not been considered for merge. @KAKwit in the mean time, you could use rivescript-promises. With that you can make your user inputs case sensitive by passing it as a parameter to the Rivescript instance:

new Rivescript({ utf8: true, caseSensitive: true })

[kirsle]

The upstream code has changed quite a bit now (moving from CoffeeScript back to vanilla JS); mind rebasing this PR on the latest master?

[kirsle]

Hey guys, better late than never, I ported this PR onto the modern JavaScript base of rivescript-js and merged it in #378.

RiveScript.js v2.2.0 adds the caseInsensitive option to the constructor. Sorry I've neglected this for so long, thanks guys!