Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration files for long control simulations #208

Merged
merged 15 commits into from
Mar 31, 2020

Conversation

oliverwm1
Copy link
Contributor

This PR updates the single_fv3gfs_runs workflow. Specifically, it adds configurations for year-long control runs (both free-running and nudged) and updates the diag_tables to include monthly-mean averages in the output, and a few more variables at higher frequency.

It also makes a small simplification to the submit_jobs.py script.

@AnnaKwa
Copy link
Contributor

AnnaKwa commented Mar 30, 2020

Could the name of the workflow be a bit more descriptive of the type of jobs it contains (long control runs)? Also could you add your description into a short README snippet?

Copy link
Contributor

@AnnaKwa AnnaKwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File changes look good to me. Just a couple minor comments.

@oliverwm1
Copy link
Contributor Author

Could the name of the workflow be a bit more descriptive of the type of jobs it contains (long control runs)? Also could you add your description into a short README snippet?

The workflow already exists, so I'd prefer to not rename it unless you feel strongly.

Good call on updating the README. I added a table of all the configurations that are currently in the workflow. Let me know if you think it needs more.

@AnnaKwa
Copy link
Contributor

AnnaKwa commented Mar 31, 2020

Oh, I see. I thought this was a new workflow for just long control runs. As long as the usage is described in the README, I'm fine with this. Approved!

@oliverwm1 oliverwm1 merged commit 5a5d8e4 into master Mar 31, 2020
@oliverwm1 oliverwm1 deleted the feature/nudged-run-fv3atm branch March 31, 2020 01:12
spencerkclark pushed a commit that referenced this pull request May 7, 2021
* API: user_project falls back to project

Closes #207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants