Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save lat/lon grid variables from sfc_dt_atmos #204

Merged
merged 2 commits into from
Mar 30, 2020

Conversation

AnnaKwa
Copy link
Contributor

@AnnaKwa AnnaKwa commented Mar 27, 2020

Adds the lat/lon grid vars to list of vars to save so that the grid info is present for training data.

@AnnaKwa AnnaKwa requested a review from nbren12 March 27, 2020 20:51
@AnnaKwa
Copy link
Contributor Author

AnnaKwa commented Mar 27, 2020

Need additional adjustments- reopen after tests passed.

@AnnaKwa AnnaKwa closed this Mar 27, 2020
@AnnaKwa
Copy link
Contributor Author

AnnaKwa commented Mar 27, 2020

Fixed

@AnnaKwa AnnaKwa reopened this Mar 27, 2020
Copy link
Contributor

@brianhenn brianhenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving this an approval so it can unblock the workflows -- thanks for catching and fixing

Update: I guess this wasn't necessary since we're not on master :)

@AnnaKwa AnnaKwa merged commit 906eb69 into develop-one-steps Mar 30, 2020
@AnnaKwa AnnaKwa deleted the feature/save-latlon-grid-vars branch March 30, 2020 18:28
nbren12 added a commit that referenced this pull request Apr 13, 2020
* Feature/one step save baseline (#193)

This adds several features to the one-step pipeline

- big zarr. Everything is stored as one zarr file
- saves physics outputs
- some refactoring of the job submission.

Sample output: https://gist.github.com/nbren12/84536018dafef01ba5eac0354869fb67

* save lat/lon grid variables from sfc_dt_atmos (#204)

* save lat/lon grid variables from sfc_dt_atmos

* Feature/use onestep zarr train data (#207)

Use the big zarr from the one step workflow as input to the create training data pipeline

* One-step sfc variables time alignment (#214)

This makes the diagnostics variables appended to the big zarr have the appropriate step and forecast_time dimensions, just as the variables extracted by the wrapper do.

* One step zarr fill values (#223)

This accomplishes two things: 1) preventing true model 0s from being cast to NaNs in the one-step big zarr output, and 2) initializing big zarr arrays with NaNs via full so that if they are not filled in due to a failed timestep or other reason, it is more apparent than using empty which produces arbitrary output.

* adjustments to be able to run workflows in dev branch (#218)

Remove references to hard coded dims and data variables or imports from vcm.cubedsphere.constants, replace with arguments.
Can provide coords and dims as args for mappable var

* One steps start index (#231)

Allows for starting the one-step jobs at the specified index in the timestep list to allow for testing/avoiding spinup timesteps

* Dev fix/integration tests (#234)

* change order of required args so output is last

* fix arg for onestep input to be dir containing big zarr

* update end to end integration test ymls

* prognostic run adjustments

* Improved fv3 logging (#225)

This PR introduces several improvements to the logging capability of our prognostic run image

- include upstream changes to disable output capturing in `fv3config.fv3run`
- Add `capture_fv3gfs_func` function. When called this capture the raw fv3gfs outputs and re-emit it as DEBUG level logging statements that can more easily be filtered.
- Refactor `runtime` to `external/runtime/runtime`. This was easy since it did not depend on any other module in fv3net. (except implicitly the code in `fv3net.regression` which is imported when loading the sklearn model with pickle).
- updates fv3config to master

* manually merge in the refactor from master while keeping new names from develop (#237)

* lint

* remove logging from testing

* Dev fix/arg order (#238)

* update history

* fix positional args

* fix function args

* update history

* linting

Co-authored-by: Anna Kwa <[email protected]>
Co-authored-by: brianhenn <[email protected]>
spencerkclark pushed a commit that referenced this pull request May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants