-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add exception handling and retry on loading train batch #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for adding the logging statements!
I found the exception handling in _create_training_batch_with_retries
a bit hard to follow. What do you think about just doing the retries no matter what the exact ValueError
is?
Thanks for the review @oliverwm1 - I left a comment about the retry exception, let me know what you think. Ready for re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Pre commit config, flake8, black
This allows the model training to proceed by skipping a batch if it runs into data quality or read issues. It will also save the actual number of batches used in the final config copy.