Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Poe Llama-2-70b, Code-Llama-34b, and Google-PaLM-2 bots #656

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

PeterDaveHello
Copy link
Collaborator

Should leverage Poe to provide so many opportunities 🤩

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chatall ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 10:32am

@PeterDaveHello
Copy link
Collaborator Author

@sunner I'm not familiar with the project yet, so it would really need your review to help confirm if it's good enough. Thanks.

@sunner
Copy link
Member

sunner commented Dec 6, 2023

Thank you, Peter. The PR is great!

Have you ever tested them? I guess not. The bots must be imported into src/bots/index.js to take effect.

Moreover, I will give you three new logo files.

@PeterDaveHello
Copy link
Collaborator Author

No, I haven't tested them, you're right. I'll update the src/bots/index.js, thanks.

BTW, maybe there should be a more effective and efficient way to use the logo files, like just the same base image, but draw the context window number and platform logo above them in the UI, so you don't need to manually maintain all the logo files?

@PeterDaveHello
Copy link
Collaborator Author

@sunner I updated the PR, would you like to take a look? Thanks!

Copy link
Member

@sunner sunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improvements. The following logos are codellama-poe-logo.png and llama-2-70b-logo
codellama-poe-logo
llama-2-70b-logo

Comment on lines 79 to 80
Llama270bPoeBot.getInstance(),
GooglePalm2PoeBot.getInstance(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two bots should be inserted based on the alpha order of model name.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fair, but it looks like the current bots are not really in order? 🤣 That make me not sure which order is correct, as it doesn't seem to be a good idea to sort them all in this pull request 😅

https://github.com/sunner/ChatALL/blob/main/src/bots/index.js#L60-L63

https://github.com/sunner/ChatALL/blob/main/src/bots/index.js#L77-L95

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class names are not model names for some reason. For example, the model of SageBot is called Assistant.

If you can not make sure the order, feel free to leave it to me.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let me try it first 😅 I will let you know if you'd leave it to you 😆

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunner Please help take a look if it's now good enough 😄

Comment on lines +154 to +156
bots.getBotByClassName("Llama270bPoeBot"),
bots.getBotByClassName("GooglePalm2PoeBot"),
bots.getBotByClassName("CodeLlama34bPoeBot"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Llama & CodeLlama are also open sourced and should be added to open-source tag also.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, it's done!

@sunner
Copy link
Member

sunner commented Dec 7, 2023

BTW, maybe there should be a more effective and efficient way to use the logo files, like just the same base image, but draw the context window number and platform logo above them in the UI, so you don't need to manually maintain all the logo files?

Good point! Since there are too many bots, it really needs a better way to organize them.

@sunner
Copy link
Member

sunner commented Jan 13, 2024

Thank you very much. The PR will be included in next release.

@PeterDaveHello PeterDaveHello deleted the EnhancePoe branch January 14, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants