-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Poe Llama-2-70b, Code-Llama-34b, and Google-PaLM-2 bots #656
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@sunner I'm not familiar with the project yet, so it would really need your review to help confirm if it's good enough. Thanks. |
Thank you, Peter. The PR is great! Have you ever tested them? I guess not. The bots must be imported into Moreover, I will give you three new logo files. |
No, I haven't tested them, you're right. I'll update the BTW, maybe there should be a more effective and efficient way to use the logo files, like just the same base image, but draw the context window number and platform logo above them in the UI, so you don't need to manually maintain all the logo files? |
52b83b0
to
4cbfbc3
Compare
@sunner I updated the PR, would you like to take a look? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/bots/index.js
Outdated
Llama270bPoeBot.getInstance(), | ||
GooglePalm2PoeBot.getInstance(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two bots should be inserted based on the alpha order of model name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds fair, but it looks like the current bots are not really in order? 🤣 That make me not sure which order is correct, as it doesn't seem to be a good idea to sort them all in this pull request 😅
https://github.com/sunner/ChatALL/blob/main/src/bots/index.js#L60-L63
https://github.com/sunner/ChatALL/blob/main/src/bots/index.js#L77-L95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class names are not model names for some reason. For example, the model of SageBot
is called Assistant
.
If you can not make sure the order, feel free to leave it to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, let me try it first 😅 I will let you know if you'd leave it to you 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sunner Please help take a look if it's now good enough 😄
bots.getBotByClassName("Llama270bPoeBot"), | ||
bots.getBotByClassName("GooglePalm2PoeBot"), | ||
bots.getBotByClassName("CodeLlama34bPoeBot"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Llama & CodeLlama are also open sourced and should be added to open-source tag also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, it's done!
Good point! Since there are too many bots, it really needs a better way to organize them. |
4cbfbc3
to
b8f57d6
Compare
Thank you very much. The PR will be included in next release. |
Should leverage Poe to provide so many opportunities 🤩