refactor: implementing the historical context of LangChainBot using the BufferMemory encapsulated by LangChain #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 7, 2023 20:50
… the BufferMemory encapsulated by LangChain.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you very much! Introducing more LangChain features are exactly in the plan. I have only one consideration. The Chat Title is not always unique. Is it a good choice of key? How about continuing using chatContext to restore messages? |
… the BufferMemory encapsulated by LangChain.
|
Yes, thank you for your suggestion. I have revised the code again, reducing the amount of previous modifications. Perhaps my previous modification ideas were too greedy, hahaha |
… the BufferMemory encapsulated by LangChain.
sunner
requested changes
Sep 9, 2023
… the BufferMemory encapsulated by LangChain.
Thanks! You nailed it with those suggestions. I've fixed them up. |
sunner
changed the title
|
Thank you very much. The PR will be included in next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize by implementing the historical context of LangChainBot using the BufferMemory encapsulated by LangChain.