Unvendor plz-event-source and plz-media-type #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leotaku
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
leotaku
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
leotaku
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
leotaku
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
|
Hi @leotaku , Thanks for looking into this. Could you use the latest versions of those libs?
Otherwise this looks good! Thanks for working on this. |
|
Done! |
|
LGTM! |
leotaku
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
leotaku
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
leotaku
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
leotaku
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
|
Thank you for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to unvendor plz-event-source and plz-media-type. According to #46 (comment), this should not cause any problems.
I chose to define
0.1.0as the minimum required versions, because the vendored packages are seemingly older, and it seems like established Elisp practice is to specify the "lowest version that is expected to reasonably function".