Add support for auth-source secret functions to :key argument #111
Conversation
minad
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
minad
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
minad
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
minad
had a problem deploying
to
Continuous Integration
GitHub Actions
Failure
minad
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
minad
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
minad
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
|
This seems reasonable, thanks for adding it - can you also add it to Claude and Gemini, both of which use keys, plus note it in the README (perhaps with an usage example)? |
|
Also "Implements" is not a PR keyword. Use "close"/"closes" if you want to close #110 automatically :) |
|
Also, now that I joined this discussion, @ahyatt, what do you think about adding a section on GitHub Models? I introduced it to gptel, using it ever since then (and I could do the same here). It is basically an OpenAI connection to Azure, using a GitHub token as a key. |
|
@gs-101 if you'd like to send a PR about that, that's be welcome, thank you! Is there a relation to this PR, though? Like, is it only possible after we can use auth sources for keys? |
It would certainly help (since it would be easier to keep the key private), but it is not that related. Sorry for adding off-topic messages to the discussion, I just commented on it since I saw an opportunity after I joined the discussion with my previous comment. But I'll open up a PR to keep this unrelated topic from being discussed here. |
|
@minad, if you can't make the changes, I'll merge this in a few days and finish the changes I suggested, which is fine. This would be good to get into the next release. |
|
Thanks. I don't have much time right now. |
Implements #110