Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support offsets on the right hand side #9

Merged
merged 7 commits into from
Sep 5, 2016
Merged

Support offsets on the right hand side #9

merged 7 commits into from
Sep 5, 2016

Conversation

ahwillia
Copy link
Owner

@ahwillia ahwillia commented Sep 4, 2016

As per the feature request here: #6

I have a prototype working but it needs much more extensive testing. @ntezak - can you do me a favor and try checking out this branch to see if this meets your needs? Are the conventions right?

  • I only support adding/subtracting an offset
  • Offsets have to be integers
  • This doesn't work yet: This also works now:
offset = 5
@einsum A[i] = B[i+:offset]

Checklist for merging:

  • Fully document conventions (e.g. we don't always enforce equality on bounds checks now.)
  • Clean up the tests -- I'd like to use v0.5 testing but BaseTestNext is slow. I may just wrap every set of tests in a let statement for now.
  • @einsum A[i] = B[i+:offset]

@ahwillia
Copy link
Owner Author

ahwillia commented Sep 5, 2016

I'm happy with this - merging now. Will clean up documentation before tagging next version.

@ahwillia ahwillia changed the title WIP: Support offsets on the right hand side Support offsets on the right hand side Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant