Skip to content

Commit

Permalink
Revert "Options Http Enum add to Core (Azure#5246)"
Browse files Browse the repository at this point in the history
This reverts commit 7eeb609.
  • Loading branch information
ahsonkhan committed Jan 11, 2024
1 parent 88242f3 commit 764f33b
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 10 deletions.
2 changes: 0 additions & 2 deletions sdk/core/azure-core/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

## 1.11.0-beta.3 (Unreleased)

- Added 'OPTIONS' HTTP method to `Azure::Core::Http::HttpMethod` enum.

### Features Added

### Breaking Changes
Expand Down
6 changes: 0 additions & 6 deletions sdk/core/azure-core/inc/azure/core/http/http.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -159,12 +159,6 @@ namespace Azure { namespace Core { namespace Http {
*/
AZ_CORE_DLLEXPORT const static HttpMethod Patch;

/**
* @brief The representation of an `OPTIONS` HTTP method based on [RFC 2616]
* (https://datatracker.ietf.org/doc/html/rfc2616).
*/
AZ_CORE_DLLEXPORT const static HttpMethod Options;

private:
std::string m_value;
}; // extensible enum HttpMethod
Expand Down
1 change: 0 additions & 1 deletion sdk/core/azure-core/src/http/http.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ const HttpMethod HttpMethod::Post("POST");
const HttpMethod HttpMethod::Put("PUT");
const HttpMethod HttpMethod::Delete("DELETE");
const HttpMethod HttpMethod::Patch("PATCH");
const HttpMethod HttpMethod::Options("OPTIONS");

namespace {
bool IsInvalidHeaderNameChar(char c)
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/azure-core/test/libcurl-stress-test/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Where namespace will be created if missing , search directory can be any folder

ATM the docker image is build by hand and hard-coded in the chart to simplify matters.

To build the image run "docker build -t <acr>/azuresdkforcpp/curlstress:v8 --build-arg targetTest=azure-core-libcurl-stress-test --build-arg build=on -f .\Dockerfile .\..\..\..\..\..\"
To build the image run "docker build -t <acr>/azuresdkforcpp/curlstress:v8 --build-arg targetTest=azure-core-libcurl-stress-test --build-arg build=on ."

To push to mcr : "docker push <acr>/azuresdkforcpp/curlstress:v8"
Obviously after logging in to the acr "az acr login -n <acr>"
Expand Down

0 comments on commit 764f33b

Please sign in to comment.