-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
overwrite OCI source label in image #60
Conversation
Thanks @Preisschild for the contribution, which looks good to me. I see that you closed #59, which sets label in Dockerfile. It might be a little better than this PR? Also could you please update all the labels (exclude
cc @clementnuss |
The dockerfile is unused for the ko-build as far as I understand, but I can add it there too.
will do. |
You are right. Unfortunately, ko.yaml doesn't support configuring the image labels yet. |
de25473
to
637ad77
Compare
I also removed the duplicate (when |
d16c6ce
to
2aa7e0b
Compare
Currently, this label is set to `https://github.com/chainguard-images/images/tree/main/images/static` (because the ko base image is this chainguard image). This leads to issues with dependency managers like renovate, which uses this label to parse the change log. Setting this label to the correct source URL fixes such problems. More Information on those labels: https://github.com/opencontainers/image-spec/blob/main/annotations.md#pre-defined-annotation-keys ko-build/ko#1395 https://docs.renovatebot.com/modules/datasource/docker/#description Signed-off-by: Florian Ströger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @Preisschild
Will release a new version today or tomorrow. |
Just released https://github.com/ahrtr/etcd-defrag/releases/tag/v0.21.0 The latest labels:
|
Currently, this label is set to
https://github.com/chainguard-images/images/tree/main/images/static
(because the ko base image is this chainguard image).This leads to issues with dependency managers like renovate, which uses this label to parse the change log.
Setting this label to the correct source URL fixes such problems.
More Information on those labels:
https://github.com/opencontainers/image-spec/blob/main/annotations.md#pre-defined-annotation-keys
ko-build/ko#1395
https://docs.renovatebot.com/modules/datasource/docker/#description