Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web,otel: add url to span name #28

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

tatchi
Copy link
Contributor

@tatchi tatchi commented Jul 30, 2024

This PR suggests adding the url to the span name. This is not spec-compliant

HTTP client spans have no http.route attribute since client-side instrumentation is not generally aware of the "route", and therefore HTTP client span names SHOULD be {method}.

But I think it's a nice QOL improvement. We get more information right away, instead of seeing a bunch of lines in Grafana with just the method name.

Showing the full url might be a bit verbose in some cases, I think ideally we should extract the different parts, but that would require parsing the url. And I guess adding a library like uri for this is not desirable?

@tatchi tatchi force-pushed the tatchi/add-url-span-name branch from 563b59f to 4d1c4c9 Compare November 15, 2024 13:46
@tatchi tatchi merged commit 9015595 into ahrefs:master Nov 15, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant