Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests adding the
url
to the span name. This is not spec-compliantBut I think it's a nice QOL improvement. We get more information right away, instead of seeing a bunch of lines in Grafana with just the method name.
Showing the full url might be a bit verbose in some cases, I think ideally we should extract the different parts, but that would require parsing the url. And I guess adding a library like
uri
for this is not desirable?