-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Update Zsh completions and add Oh-My-Zsh plugin #128
Conversation
@jackwrfuller Thanks for this! I like your idea of having a dedicated plugin, but want to discuss. If we were to create another repo for the Options I see are:
|
In my opinion, having it as a separate repo would be easier to maintain and easier to install. It is more in line with how other custom oh-my-zsh plugins operate, e.g zsh-autosuggestions as I linked above.
which in our case could become:
|
Ok @jackwrfuller sounds good! I've created the repo, please go ahead moving the Zsh completion plugin from your current PR into the new repo 👍 https://github.com/ahoy-cli/zsh-ahoy 🚀 Note: if possible, please make the plugin as generic as possible so it can work for anyone using Zsh, not just Oh-My-Zsh users (e.g. I use the Sheldon Zsh plugin manager for my plugins) 😄 |
I have created the initial PR for zsh-ahoy: ahoy-cli/zsh-ahoy#1 I will now update this PR to remove the autocomplete directory and update the zsh completion instructions. I'm not familiar with Sheldon, but i have included installation instructions for just bare zsh. I can look into Sheldon soon if you would like me to. |
The ZSH completions (as they are currently documented) are broken.
This PR uses the correct autocompletion script, taken upstream from urfave/cli (Note the urfave/cli/v1 version, since thats what
ahoy
currently uses).I think a better solution ultimately will be to create a new
ahoy-cli/zsh-ahoy
that is especially designed to house the autocompletion functionality, including the Oh-My-Zsh custom plugin that I have written (c.f zsh-autosuggestions).