-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add support for env files #126
Merged
ocean
merged 10 commits into
ahoy-cli:master
from
jackwrfuller:feature/environment-variables
Dec 16, 2024
Merged
[Feature] Add support for env files #126
ocean
merged 10 commits into
ahoy-cli:master
from
jackwrfuller:feature/environment-variables
Dec 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for these two PRs @jackwrfuller 🙌 I'll have a look in the next couple of days and make a new release. |
AlexSkrypnyk
requested changes
Dec 9, 2024
AlexSkrypnyk
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ocean Could you please review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment variable files (i.e ".env") are a commonly used method to define and manage project specific secrets and configuration.
It is standard for yaml-like projects to allow you to access env vars you have defined in env files in your project. For example, Docker Compose will read variables defined in an ".env" file by default without any configuration.
Currently, to access a variable
FOO=bar
defined in a file ".env" in a command, you would need prepend asource .env
to the command each and every time:This is tiresome and error-prone. In my proposed PR, we would allow the user to define global and command-level env files. For example:
In the case where a command has both the global and command-level env files set, and these files contain conflicting variable definitions, I propose that the command-level env file overrides the global one.
Also, as it is currently implemented the filepath provided to the
env:
yaml key must be relative to the Ahoy source directory; see for example: