Skip to content

Commit

Permalink
fix(codecs) csv encoding quoting bug (vectordotdev#18320)
Browse files Browse the repository at this point in the history
* added additional csv configuration options
found potential bug on writing lines with quoted fields

* implemented suggestions of pront

* added configurable QuotingStyle and made problematic quoted tests pass for now

* switched to defaults by serde

* refactor csv codec to use low level csv-core to fix missing closing quote bug

* fixed typo

* use field iterator to count written filds instead of manual counter

* moved internal_buffer into CsvSerializer to not recreated with every call to encode()

* improoved comments

* implemented suggestions

* cleanup

* refactored test

* low level csv writer api refactor

* Revert "low level csv writer api refactor"

This reverts commit c730d58.

* some more cleanup

* generate-component-docs
  • Loading branch information
scMarkus authored Aug 29, 2023
1 parent e39d9b3 commit 93ad80d
Show file tree
Hide file tree
Showing 29 changed files with 2,340 additions and 283 deletions.
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/codecs/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ publish = false
apache-avro = { version = "0.15.0", default-features = false }
bytes = { version = "1", default-features = false }
chrono = { version = "0.4", default-features = false }
csv = { version = "1.2", default-features = false }
csv-core = { version = "0.1.10", default-features = false }
derivative = { version = "2", default-features = false }
dyn-clone = { version = "1", default-features = false }
lookup = { package = "vector-lookup", path = "../vector-lookup", default-features = false }
Expand Down
Loading

0 comments on commit 93ad80d

Please sign in to comment.