Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go1.20] tool doesn't recurse into sub-directories #61

Open
dprotaso opened this issue Feb 27, 2023 · 2 comments
Open

[go1.20] tool doesn't recurse into sub-directories #61

dprotaso opened this issue Feb 27, 2023 · 2 comments

Comments

@dprotaso
Copy link

Unsure why but with go1.20 the tool doesn't recurse into sub-directories anymore.

Script is invoked the following way
https://github.com/knative/eventing/blob/main/hack/update-reference-docs.sh

Output is

I0227 10:51:28.226464   96710 main.go:132] parsing go packages in directory knative.dev/eventing/pkg/apis
F0227 10:51:28.242770   96710 main.go:135] no loaded build package for knative.dev/eventing/pkg/apis
exit status 255
@dprotaso dprotaso mentioned this issue Mar 6, 2023
Closed
@dprotaso
Copy link
Author

dprotaso commented Mar 8, 2023

gengo - issue - kubernetes/gengo#241

@dprotaso
Copy link
Author

dprotaso commented Mar 8, 2023

Workaround is to place an empty go file into the empty directory so that there is always code

@dprotaso dprotaso mentioned this issue Mar 10, 2023
Merged
dprotaso added a commit to dprotaso/eventing that referenced this issue Mar 10, 2023
@dprotaso
fix api docs generation with go1.20
a9e93fc 
Context ahmetb/gen-crd-api-reference-docs#61
dprotaso added a commit to dprotaso/eventing that referenced this issue Mar 10, 2023
@dprotaso
fix api docs generation with go1.20
bf0ca8d 
Context ahmetb/gen-crd-api-reference-docs#61
knative-prow bot pushed a commit to knative/eventing that referenced this issue Mar 14, 2023
@dprotaso
fix api docs generation with go1.20 (#6810)
ea0b254 
Context ahmetb/gen-crd-api-reference-docs#61

This fixes the `knative/pkg` downstream tests (which is using go1.20)
vishal-chdhry pushed a commit to vishal-chdhry/eventing that referenced this issue Mar 14, 2023
@dprotaso @vishal-chdhry
fix api docs generation with go1.20 (knative#6810)
a5a4238 
Context ahmetb/gen-crd-api-reference-docs#61

This fixes the `knative/pkg` downstream tests (which is using go1.20)
vishal-chdhry pushed a commit to vishal-chdhry/eventing that referenced this issue Apr 25, 2023
@dprotaso @vishal-chdhry
fix api docs generation with go1.20 (knative#6810)
b93b668 
Context ahmetb/gen-crd-api-reference-docs#61

This fixes the `knative/pkg` downstream tests (which is using go1.20)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dprotaso